netdev - Re: [PATCH net-next 2/9] bnxt_en: Add Support for ETHTOOL_GMODULEINFO and ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLinShcLykdPDUN0wBb1f10_i8MyLZXZt4jObKuZADU+ezA@mail.gmail.com>
Date:	Sat, 14 May 2016 23:01:18 -0700
From:	Michael Chan <michael.chan@...adcom.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	David Miller <davem@...emloft.net>, Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/9] bnxt_en: Add Support for ETHTOOL_GMODULEINFO
 and ETHTOOL_GMODULEEEPRO

On Sat, May 14, 2016 at 6:31 PM, Ben Hutchings <ben@...adent.org.uk> wrote:
> On Sat, 2016-05-14 at 20:29 -0400, Michael Chan wrote:
>> From: Ajit Khaparde <ajit.khaparde@...adcom.com>
> [...]
>> +     /* Read A2 portion of the EEPROM */
>> +     if (length) {
>> +             start -= ETH_MODULE_SFF_8436_LEN;
>> +             bnxt_read_sfp_module_eeprom_info(bp, I2C_DEV_ADDR_A2, 1, start,
>> +                                              length, data + start);
>
> The output address calculation (data + start) makes no sense at all.
> If eeprom->offset < ETH_MODULE_SFF_8436_LEN then start == 0 here and
> this read overwrites earlier data in the output buffer.  If
> eeeprom->offset > ETH_MODULE_SFF_8436_LEN then start > 0 here and this
> overruns the output buffer.
>
> I think that 'data' should be incremented along with 'start' in the
> previous if-block.
>

Yes, you're right.  We'll fix it and resend.  Thanks.