netdev - Re: [PATCH iproute2] ip link: Add support for kernel side filtering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fb315f5-43c7-bcf1-f317-dab0a352f206@cumulusnetworks.com>
Date:	Mon, 16 May 2016 12:27:25 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] ip link: Add support for kernel side filtering

On 5/16/16 12:19 PM, Stephen Hemminger wrote:
> On Wed, 11 May 2016 06:51:58 -0700
> David Ahern <dsa@...ulusnetworks.com> wrote:
>
>> Kernel gained support for filtering link dumps with commit dc599f76c22b
>> ("net: Add support for filtering link dump by master device and kind").
>> Add support to ip link command. If a user passes master device or
>> kind to ip link command they are added to the link dump request message.
>>
>> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
>> ---
>>  include/libnetlink.h |  6 ++++++
>>  ip/ipaddress.c       | 33 ++++++++++++++++++++++++++++++++-
>>  lib/libnetlink.c     | 28 ++++++++++++++++++++++++++++
>>  3 files changed, 66 insertions(+), 1 deletion(-)
>>
>
> Was this tested on older kernels?  Don't want to add something that breaks
> when run on old kernels that are in stable distros.
>

Yes. Not really far back but older 4.x kernels.

In general older kernels do not parse the attributes appended to the get 
request. This is very similar to the neigh filter added by 
b8c753245bad3f13a03b105b724ff406d278c753.