netdev - Re: [PATCH v5 net-next 03/14] ipv6: Fix nexthdr for reinjection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALx6S34RXj_y6sAiv+q6RPVtXo6HUZ04mNCjR73sjyyJM9UjnA@mail.gmail.com>
Date:	Mon, 16 May 2016 11:35:04 -0700
From:	Tom Herbert <tom@...bertland.com>
To:	Shmulik Ladkani <shmulik.ladkani@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v5 net-next 03/14] ipv6: Fix nexthdr for reinjection

On Mon, May 16, 2016 at 11:19 AM, Shmulik Ladkani
<shmulik.ladkani@...il.com> wrote:
> Hi,
>
> On Sun, 15 May 2016 16:42:24 -0700 Tom Herbert <tom@...bertland.com> wrote:
>> In ip6_input_finish the nexthdr protocol is retrieved from the
>> next header offset that is returned in the cb of the skb.
>> This method does not work for UDP encapsulation that may not
>> even have a concept of a nexthdr field (e.g. FOU).
>>
>> This patch checks for a final protocol (INET6_PROTO_FINAL) when a
>> protocol handler returns > 1. If the protocol is not final then
>
> If you respin due to other reasons:  s/> 1/> 0/
>
Will do. Thanks!

Tom

>> resubmission is performed on nhoff value. If the protocol is final
>> then the nexthdr is taken to be the return value.
>>
>> Signed-off-by: Tom Herbert <tom@...bertland.com>
>
> Reviewed-by: Shmulik Ladkani <shmulik.ladkani@...il.com>