netdev - Re: [PATCH] phy: remove irq param to fix crash in fixed_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160516131134.GA31094@lnxartpec.se.axis.com>
Date:	Mon, 16 May 2016 15:11:35 +0200
From:	Rabin Vincent <rabin@....in>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	Rabin Vincent <rabin.vincent@...s.com>,
	"David S. Miller" <davem@...emloft.net>, f.fainelli@...il.com,
	netdev@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
	linux-mips@...ux-mips.org, devicetree@...r.kernel.org,
	Rabin Vincent <rabinv@...s.com>
Subject: Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()

On Mon, May 16, 2016 at 02:29:03PM +0200, Andrew Lunn wrote:
> What i think is better is to make fixed_phy_add() return -EPROBE_DEFER
> if it is called before fixed_mdio_bus_init().

I don't see how this will work for platforms such as ar7 and bcm47xx
which call fixed_phy_add() from platform code.  There is no probe to
retry there so while the EPROBE_DEFER will certainly fix the crash it
will also leave the platforms without a phy.