netdev - Re: [PATCH net-next v2 0/6] hv_netvsc: avoid races on mtu change/set channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160516.132721.1902162567878052610.davem@davemloft.net>
Date:	Mon, 16 May 2016 13:27:21 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vkuznets@...hat.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, haiyangz@...rosoft.com,
	kys@...rosoft.com, LinoSanfilippo@....de
Subject: Re: [PATCH net-next v2 0/6] hv_netvsc: avoid races on mtu
 change/set channels

From: Vitaly Kuznetsov <vkuznets@...hat.com>
Date: Fri, 13 May 2016 13:55:19 +0200

> Changes since v1:
> - Rebased to net-next [Haiyang Zhang]
> 
> Original description:
> 
> MTU change and set channels operations are implemented as netvsc device
> re-creation destroying internal structures (struct net_device stays). This
> is really unfortunate but there is no support from Hyper-V host to do it
> in a different way. Such re-creation is unsurprisingly racy, Haiyang
> reported a crash when netvsc_change_mtu() is racing with
> netvsc_link_change() but I was able to identify additional races upon
> investigation. Both netvsc_set_channels() and netvsc_change_mtu() race
> against:
> 1) netvsc_link_change()
> 2) netvsc_remove()
> 3) netvsc_send()
> 
> To solve these issues without introducing new locks some refactoring is
> required. We need to get rid of very complex link graph in all the
> internal structures and avoid traveling through structures which are being
> removed.

Series applied, thanks.