netdev - Re: [PATCH] net: qrtr: fix build problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160516.134512.245412616243380218.davem@davemloft.net>
Date:	Mon, 16 May 2016 13:45:12 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	arnd@...db.de
Cc:	bjorn.andersson@...ymobile.com, courtney.cavin@...ymobile.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: qrtr: fix build problems

From: Arnd Bergmann <arnd@...db.de>
Date: Fri, 13 May 2016 15:09:58 +0200

> Having multiple loadable modules with the same name cannot work
> with modprobe, and having both net/qrtr/smd.ko and drivers/soc/qcom/smd.ko
> results in a (somewhat cryptic) build error:
> 
> ERROR: "qcom_smd_driver_unregister" [net/qrtr/smd.ko] undefined!
> ERROR: "qcom_smd_driver_register" [net/qrtr/smd.ko] undefined!
> ERROR: "qcom_smd_set_drvdata" [net/qrtr/smd.ko] undefined!
> ERROR: "qcom_smd_send" [net/qrtr/smd.ko] undefined!
> ERROR: "qcom_smd_get_drvdata" [net/qrtr/smd.ko] undefined!
> ERROR: "qcom_smd_driver_unregister" [drivers/soc/qcom/wcnss_ctrl.ko] undefined!
> ERROR: "qcom_smd_driver_register" [drivers/soc/qcom/wcnss_ctrl.ko] undefined!
> ERROR: "qcom_smd_set_drvdata" [drivers/soc/qcom/wcnss_ctrl.ko] undefined!
> ERROR: "qcom_smd_send" [drivers/soc/qcom/wcnss_ctrl.ko] undefined!
> ERROR: "qcom_smd_get_drvdata" [drivers/soc/qcom/wcnss_ctrl.ko] undefined!
> 
> Also, the qrtr driver uses the SMD interface and has a Kconfig dependency,
> but also allows for compile-testing when SMD is disabled. However, if
> with QCOM_SMD=m and COMPILE_TEST=y we can end up with QRTR_SMD=y and
> that fails with a related link error.
> 
> The changes the dependency so we can still compile-test the driver but
> not have it built-in if SMD is a module, to avoid running in the broken
> configuration, and changes the Makefile to provide the driver under
> a different module name.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: bdabad3e363d ("net: Add Qualcomm IPC router")

Applied.