netdev - Re: [PATCH] net/hsr: Use setup_timer and mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160516.140107.648493980838894656.davem@davemloft.net>
Date:	Mon, 16 May 2016 14:01:07 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	falakreyaz@...il.com
Cc:	arvid.brodin@...en.se, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/hsr: Use setup_timer and mod_timer.

From: Muhammad Falak R Wani <falakreyaz@...il.com>
Date: Sun, 15 May 2016 19:37:44 +0530

> The function setup_timer combines the initialization of a timer with the
> initialization of the timer's function and data fields. The mulitiline
> code for timer initialization is now replaced with function setup_timer.
> 
> Also, quoting the mod_timer() function comment:
> -> mod_timer() is a more efficient way to update the expire field of an
>    active timer (if the timer is inactive it will be activated).
> 
> Use setup_timer() and mod_timer() to setup and arm a timer, making the
> code compact and aid readablity.
> 
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@...il.com>

Applied.