lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 17 May 2016 11:35:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	amitg.b14@...il.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] net: Fix coding style warnings and errors.

From: Amit Ghadge <amitg.b14@...il.com>
Date: Tue, 17 May 2016 08:46:30 +0530

> Clean up checkpatch warnings and errors:
> 
> * WARNING: Block comments use * on subsequent lines
> * WARNING: Missing a blank line after declarations
> * WARNING: networking block comments don't use an empty /* line, use /*
> * ERROR: code indent should use tabs where possible
> * WARNING: please, no space before tabs
> * WARNING: please, no spaces at the start of a line
> * WARNING: line over 80 characters
> * ERROR: space prohibited after that open parenthesis '('
> 
> Signed-off-by: Amit Ghadge <amitg.b14@...il.com>

I hate robotic checkpatch fixes like this.

> @@ -58,8 +59,7 @@ static int __init probe_list2(int unit, struct devprobe2 *p, int autoprobe)
>  	return -ENODEV;
>  }
>  
> -/*
> - * ISA probes that touch addresses < 0x400 (including those that also
> +/*ISA probes that touch addresses < 0x400 (including those that also
>   * look for EISA/PCI cards in addition to ISA cards).
>   */

You're making the comment look worse not better, because you don't even
have a space between the "/*" and "ISA".

Honestly, does that look nice when you look at it?

If you're not going to put thought and serious consideration into this
change, don't do it at all, thank you.

Powered by blists - more mailing lists