netdev - Re: [PATCH v3 -net-next] ravb: Add missing free_irq() calls to ravb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 May 2016 12:28:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	geert+renesas@...der.be
Cc:	sergei.shtylyov@...entembedded.com, horms+renesas@...ge.net.au,
	ykaneko0929@...il.com, netdev@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v3 -net-next] ravb: Add missing free_irq() calls to
 ravb_close()

From: Geert Uytterhoeven <geert+renesas@...der.be>
Date: Tue, 17 May 2016 11:05:34 +0200

> When reopening the network device on ra7795/salvator-x, e.g. after a
> DHCP timeout:
> 
>     IP-Config: Reopening network devices...
>     genirq: Flags mismatch irq 139. 00000000 (eth0:ch0:rx_be) vs. 00000000 (ravb e6800000.ethernet eth0: cannot request IRQ eth0:ch0:rx_be
>     IP-Config: Failed to open eth0
>     IP-Config: No network devices available
> 
> The "mismatch" is due to requesting an IRQ that is already in use,
> while IRQF_PROBE_SHARED wasn't set.
> 
> However, the real cause is that ravb_close() doesn't release any of the
> R-Car Gen3-specific secondary IRQs.
> 
> Add the missing free_irq() calls to fix this.
> 
> Fixes: f51bdc236b6c5835 ("ravb: Add dma queue interrupt support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Acked-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

Applied.