netdev - Re: [PATCH 1/1] rtlwifi: rtl8192ee: simplify coding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <573C59E9.8090902@lwfinger.net>
Date:	Wed, 18 May 2016 07:02:49 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Heinrich Schuchardt <xypron.glpk@....de>,
	Kalle Valo <kvalo@....qualcomm.com>
Cc:	Wu Fengguang <fengguang.wu@...el.com>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] rtlwifi: rtl8192ee: simplify coding

On 05/17/2016 07:43 PM, Heinrich Schuchardt wrote:
> Simplify _rtl92ee_phy_path_adda_on.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>
> ---
>   drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c | 13 ++-----------
>   1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
> index 018340a..c2bf8d1 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
> @@ -2414,19 +2414,10 @@ static void _rtl92ee_phy_reload_mac_registers(struct ieee80211_hw *hw,
>   static void _rtl92ee_phy_path_adda_on(struct ieee80211_hw *hw, u32 *addareg,
>   				      bool is_patha_on, bool is2t)
>   {
> -	u32 pathon;
>   	u32 i;
>
> -	pathon = is_patha_on ? 0x0fc01616 : 0x0fc01616;
> -	if (!is2t) {
> -		pathon = 0x0fc01616;
> -		rtl_set_bbreg(hw, addareg[0], MASKDWORD, 0x0fc01616);
> -	} else {
> -		rtl_set_bbreg(hw, addareg[0], MASKDWORD, pathon);
> -	}
> -
> -	for (i = 1; i < IQK_ADDA_REG_NUM; i++)
> -		rtl_set_bbreg(hw, addareg[i], MASKDWORD, pathon);
> +	for (i = 0; i < IQK_ADDA_REG_NUM; i++)
> +		rtl_set_bbreg(hw, addareg[i], MASKDWORD, 0x0fc01616);
>   }
>
>   static void _rtl92ee_phy_mac_setting_calibration(struct ieee80211_hw *hw,

Initially the thought was that addareg[0] would need to be set differently for 
devices with 2 TX paths. For that reason, this routine was coded as shown. As 
that assumption is no longer valid, this change should be made.

Acked-by: Larry Finger <Larry.Finger@...inger.net>