netdev - Re: [net-next RFC 1/1] net sched actions: introduce timestamp for first time used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 May 2016 07:54:08 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Daniel Borkmann <daniel@...earbox.net>, nbd@....name,
	baronchon@...m.org, Alexander Duyck <alexander.duyck@...il.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Jiří Pírko <jiri@...nulli.us>,
	Alexei Starovoitov <alexei.starovoitov@...il.com>
Subject: Re: [net-next RFC 1/1] net sched actions: introduce timestamp for
 first time used

On 16-05-18 01:17 PM, Cong Wang wrote:
> On Tue, May 17, 2016 at 4:38 PM, Jamal Hadi Salim <jhs@...atatu.com> wrote:
>> diff --git a/net/sched/act_bpf.c b/net/sched/act_bpf.c
>> index 014f9a6..f581e01 100644
>> --- a/net/sched/act_bpf.c
>> +++ b/net/sched/act_bpf.c
>> @@ -156,6 +156,7 @@ static int tcf_bpf_dump(struct sk_buff *skb, struct tc_action *act,
>>
>>          tm.install = jiffies_to_clock_t(jiffies - prog->tcf_tm.install);
>>          tm.lastuse = jiffies_to_clock_t(jiffies - prog->tcf_tm.lastuse);
>> +       tm.firstuse = jiffies_to_clock_t(jiffies - prog->tcf_tm.firstuse);
>>          tm.expires = jiffies_to_clock_t(prog->tcf_tm.expires);
>
>
> I think it is the time to add a wrapper for these tm.XX =
> jiffies_to_clock_t(XXX).
>

Agreed. Will send a patch.
Actually I will resend the firstuse as well without RFC tag
and the wrapper one as separate patch.

cheers,
jamal