netdev - Re: [PATCH] Revert "phy: add support for a reset-gpio specification"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <573DBFD6.2050508@roeck-us.net>
Date:	Thu, 19 May 2016 06:29:58 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Fabio Estevam <fabio.estevam@....com>, davem@...emloft.net
Cc:	u.kleine-koenig@...gutronix.de, f.fainelli@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] Revert "phy: add support for a reset-gpio specification"

On 05/19/2016 06:11 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 5/18/2016 7:05 PM, Fabio Estevam wrote:
>
>> Commit da47b4572056 ("phy: add support for a reset-gpio specification")
>> causes the following xtensa qemu crash according to Guenter Roeck:
>>
>> [    9.366256] libphy: ethoc-mdio: probed
>> [    9.367389]  (null): could not attach to PHY
>> [    9.368555]  (null): failed to probe MDIO bus
>> [    9.371540] Unable to handle kernel paging request at virtual address 0000001c
>> [    9.371540]  pc = d0320926, ra = 903209d1
>> [    9.375358] Oops: sig: 11 [#1]
>
>     Of course, I'd like this patch to be reverted (as it was applied erroneously instead of my patches)... but where's the backtrace? It's not immediately clear how this code can cause kernel oops...
>

See http://www.spinics.net/lists/kernel/msg2258611.html.

Guenter

>> This reverts commit da47b4572056487fd7941c26f73b3e8815ff712a.
>>
>> Reported-by: Guenter Roeck <linux@...ck-us.net>
>> Signed-off-by: Fabio Estevam <fabio.estevam@....com>
> [...]
>> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
>> index 307f72a..e977ba9 100644
>> --- a/drivers/net/phy/phy_device.c
>> +++ b/drivers/net/phy/phy_device.c
> [...]
>> @@ -1571,16 +1570,9 @@ static int phy_probe(struct device *dev)
>>      struct device_driver *drv = phydev->mdio.dev.driver;
>>      struct phy_driver *phydrv = to_phy_driver(drv);
>>      int err = 0;
>> -    struct gpio_descs *reset_gpios;
>>
>>      phydev->drv = phydrv;
>>
>> -    /* take phy out of reset */
>> -    reset_gpios = devm_gpiod_get_array_optional(dev, "reset",
>> -                            GPIOD_OUT_LOW);
>> -    if (IS_ERR(reset_gpios))
>> -        return PTR_ERR(reset_gpios);
>> -
>>      /* Disable the interrupt if the PHY doesn't support it
>>       * but the interrupt is still a valid one
>>       */
>
> MBR, Sergei
>
>