netdev - Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 May 2016 11:17:54 -0600
From:	David Mosberger <davidm@...uge.net>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

On Thu, May 19, 2016 at 10:31 AM, Alexandre Belloni
<alexandre.belloni@...e-electrons.com> wrote:
> On 17/05/2016 at 17:35:30 -0600, David Mosberger wrote :
>> At 7.96 seconds, phy_start() gets called, but even though this enters
>> state PHY_UP, it does not trigger phy_state_machine() and therefore
>> doesn't trigger autonegotiation.  I'm not quite sure how this is
>> intended to be handled properly.  I believe Alexandre Belloni's patch
>> would do the trick:
>>
>>  http://www.spinics.net/lists/netdev/msg373324.html
>>
>> Or has this been fixed in some other way already?
>>
>
> I don't think it has, last time I checked, Florian was still thinking
> about it.

OK.  For what it's worth, I'm using your patch now.
It looks correct to me and works (always a bonus).

  --david
-- 
Love Linux kernel hacking?  Know Python?  We are hiring!  Contact us
at jobs@...uge.net