netdev - Re: [net-next RFC 1/1] net sched actions: introduce timestamp for first time used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpVP3MPAEBVn0buzkAaLzuYpba0Z5Va-V0CN_+G77eJhQQ@mail.gmail.com>
Date:	Thu, 19 May 2016 22:16:47 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Felix Fietkau <nbd@....name>, baronchon@...m.org,
	Alexander Duyck <alexander.duyck@...il.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Jiří Pírko <jiri@...nulli.us>,
	Alexei Starovoitov <alexei.starovoitov@...il.com>
Subject: Re: [net-next RFC 1/1] net sched actions: introduce timestamp for
 first time used

On Thu, May 19, 2016 at 9:38 AM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Thu, May 19, 2016 at 5:15 AM, Jamal Hadi Salim <jhs@...atatu.com> wrote:
>> On 16-05-19 07:54 AM, Jamal Hadi Salim wrote:
>>>
>>> On 16-05-18 01:17 PM, Cong Wang wrote:
>>
>>
>>>> I think it is the time to add a wrapper for these tm.XX =
>>>> jiffies_to_clock_t(XXX).
>>>>
>>>
>>> Agreed. Will send a patch.
>>> Actually I will resend the firstuse as well without RFC tag
>>> and the wrapper one as separate patch.
>>>
>>
>> Something like attached - compiles but untested.
>> I will test later and do formal submission.
>
> Looks good.

One nit: It is better if you can swap 'stm' with 'dtm',
it looks odd to put destination on the right side.