netdev - Re: [PATCH net-next] xen-netback: only deinitialized hash if it was initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160520.174218.308799409009522232.davem@davemloft.net>
Date:	Fri, 20 May 2016 17:42:18 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	paul.durrant@...rix.com
Cc:	xen-devel@...ts.xenproject.org, netdev@...r.kernel.org,
	wei.liu2@...rix.com
Subject: Re: [PATCH net-next] xen-netback: only deinitialized hash if it
 was initialized

From: Paul Durrant <paul.durrant@...rix.com>
Date: Wed, 18 May 2016 15:55:42 +0100

> A domain with a frontend that does not implement a control ring has been
> seen to cause a crash during domain save. This was apparently because
> the call to xenvif_deinit_hash() in xenvif_disconnect_ctrl() is made
> regardless of whether a control ring was connected, and hence
> xenvif_hash_init() was called.
> 
> This patch brings the call to xenvif_deinit_hash() in
> xenvif_disconnect_ctrl() inside the if clause that checks whether the
> control ring event channel was connected. This is sufficient to ensure
> it is only called if xenvif_init_hash() was called previously.
> 
> Signed-off-by: Paul Durrant <paul.durrant@...rix.com>
> Reported-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> Tested-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>

Applied, thanks.