lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 21 May 2016 21:47:33 +0200 From: Francois Romieu <romieu@...zoreil.com> To: Shuyu Wei <wsy2220@...il.com> Cc: Lino Sanfilippo <LinoSanfilippo@....de>, David Miller <davem@...emloft.net>, wxt@...k-chips.com, heiko@...ech.de, linux-rockchip@...ts.infradead.org, netdev@...r.kernel.org Subject: Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer Shuyu Wei <wsy2220@...il.com> : [...] > diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c > index a3a9392..c2447b0 100644 > --- a/drivers/net/ethernet/arc/emac_main.c > +++ b/drivers/net/ethernet/arc/emac_main.c > @@ -686,6 +686,9 @@ static int arc_emac_tx(struct sk_buff *skb, struct net_device *ndev) > > skb_tx_timestamp(skb); > > + /* Make sure timestamp is set */ > + smp_wmb(); Should be dma_wmb() (see davem's message). It's completely unrelated to SMP. -- Ueimor
Powered by blists - more mailing lists