netdev - RE: drivers/net/ethernet/qlogic/qed/qed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 May 2016 11:26:21 +0000
From:	Yuval Mintz <Yuval.Mintz@...gic.com>
To:	David Binderman <linuxdev.baldrick@...il.com>,
	netdev <netdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"dcb314@...mail.com" <dcb314@...mail.com>
CC:	Dan Carpenter <dan.carpenter@...cle.com>,
	Ariel Elior <Ariel.Elior@...gic.com>
Subject: RE: drivers/net/ethernet/qlogic/qed/qed_dcbx.c:210: pointless test ?

> Hello there,
> 
> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:210:16: warning: comparison is
> always false due to limited range of data type [-Wtype-limits]
> 
> Source code is
> 
>        if (priority < 0) {
> 
> but
> 
>     u8 tc, priority, priority_map;
> 
> 
> Regards
> 
> David Binderman

Hi David,

Dan Carpenter has already sent a fix for this one ~an hour ago.
[https://patchwork.ozlabs.org/patch/625114/]

Thanks,
Yuval