netdev - RE: [patch] qed: signedness bug in qed_dcbx_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY2PR1101MB11429E95A017F91699293F7A904E0@BY2PR1101MB1142.namprd11.prod.outlook.com>
Date:	Mon, 23 May 2016 11:06:05 +0000
From:	Sudarsana Kalluru <Sudarsana.Kalluru@...gic.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Yuval Mintz <Yuval.Mintz@...gic.com>
CC:	Ariel Elior <Ariel.Elior@...gic.com>,
	Dept-Eng Everest Linux L2 <everest-linux-l2@...gic.com>,
	netdev <netdev@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [patch] qed: signedness bug in qed_dcbx_process_tlv()

Thanks, Dan.
Acked-by: Sudarsana Reddy Kalluru <sudarsana.kalluru@...gic.com>

-----Original Message-----
From: Dan Carpenter [mailto:dan.carpenter@...cle.com] 
Sent: 23 May 2016 15:50
To: Yuval Mintz <Yuval.Mintz@...gic.com>; Sudarsana Kalluru <Sudarsana.Kalluru@...gic.com>
Cc: Ariel Elior <Ariel.Elior@...gic.com>; Dept-Eng Everest Linux L2 <everest-linux-l2@...gic.com>; netdev <netdev@...r.kernel.org>; kernel-janitors@...r.kernel.org
Subject: [patch] qed: signedness bug in qed_dcbx_process_tlv()

"priority" needs to be signed for the error handling to work.

Fixes: 39651abd2814 ('qed: add support for dcbx.')
Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
---
Applies to the main net tree.

diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
index cbf58e1..a06d19a 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
@@ -192,9 +192,10 @@ qed_dcbx_process_tlv(struct qed_hwfn *p_hwfn,
 		     struct dcbx_app_priority_entry *p_tbl,
 		     u32 pri_tc_tbl, int count, bool dcbx_enabled)  {
-	u8 tc, priority, priority_map;
+	u8 tc, priority_map;
 	enum dcbx_protocol_type type;
 	u16 protocol_id;
+	int priority;
 	bool enable;
 	int i;