netdev - Re: [PATCH net v2] fou: avoid using sk_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXeoX_e2wi_gOMW_2VKMzAkEJ-J37tLZfsaDGwmiut7QA@mail.gmail.com>
Date:	Mon, 23 May 2016 14:05:17 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Simon Horman <simon.horman@...ronome.com>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Tom Herbert <tom@...bertland.com>
Subject: Re: [PATCH net v2] fou: avoid using sk_user_data before it is initialised

On Mon, May 23, 2016 at 1:59 PM, David Miller <davem@...emloft.net> wrote:
> From: Simon Horman <simon.horman@...ronome.com>
> Date: Fri, 20 May 2016 14:57:17 +0900
>
>> During initialisation sk->sk_user_data should not be used before
>> it is initialised.
>>
>> Found by bisection after noticing the following:
>  ...
>> Fixes: d92283e338f6 ("fou: change to use UDP socket GRO")
>> Signed-off-by: Simon Horman <simon.horman@...ronome.com>
>> ---
>> v2
>> * Updated implementation to simply access fou->protocol directly
>>   as suggested by Tom Herbert and Cong Want
>
> I think this was resolved in another way meanwhile.  If a fix is still
> needed, please respin.

This fix is only needed for -stable to backport, because Tom's
fix is within a series of patches, which makes it hard to backport.