netdev - Re: [PATCH] net/tipc: fix potential null pointer dereference in several tipc netlink compat functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160523.144105.861691009093620479.davem@davemloft.net>
Date:	Mon, 23 May 2016 14:41:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sploving1@...il.com
Cc:	jon.maloy@...csson.com, ying.xue@...driver.com,
	netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH] net/tipc: fix potential null pointer dereference in
 several tipc netlink compat functions

From: Baozeng Ding <sploving1@...il.com>
Date: Sun, 22 May 2016 00:22:48 +0800

> @@ -916,10 +970,16 @@ static int tipc_nl_compat_sk_dump(struct
> tipc_nl_compat_msg *msg,
>  static int tipc_nl_compat_media_dump(struct tipc_nl_compat_msg *msg,
>                       struct nlattr **attrs)
>  {
> +    int err;
>      struct nlattr *media[TIPC_NLA_MEDIA_MAX + 1];
> 

Local variable declarations shall be ordered from longest to shortest
line (also known as "reverse christmas tree format").

Please fix this up in your entire patch.

Also, please format your commit message properly to ~80 columns.  I
see a mix of long and very short lines, which means you were just adding
line breaks and not filling the rest of the line out to ~80 columns
as you should.

Thanks.