netdev - Re: [PATCH net] bpf, inode: disallow userns mounts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160523.150901.61113479651269879.davem@davemloft.net>
Date:	Mon, 23 May 2016 15:09:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	daniel@...earbox.net
Cc:	alexei.starovoitov@...il.com, hannes@...essinduktion.org,
	ebiederm@...ssion.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] bpf, inode: disallow userns mounts

From: Daniel Borkmann <daniel@...earbox.net>
Date: Sun, 22 May 2016 23:16:18 +0200

> Follow-up to commit e27f4a942a0e ("bpf: Use mount_nodev not mount_ns
> to mount the bpf filesystem"), which removes the FS_USERNS_MOUNT flag.
> 
> The original idea was to have a per mountns instance instead of a
> single global fs instance, but that didn't work out and we had to
> switch to mount_nodev() model. The intent of that middle ground was
> that we avoid users who don't play nice to create endless instances
> of bpf fs which are difficult to control and discover from an admin
> point of view, but at the same time it would have allowed us to be
> more flexible with regard to namespaces.
> 
> Therefore, since we now did the switch to mount_nodev() as a fix
> where individual instances are created, we also need to remove userns
> mount flag along with it to avoid running into mentioned situation.
> I don't expect any breakage at this early point in time with removing
> the flag and we can revisit this later should the requirement for
> this come up with future users. This and commit e27f4a942a0e have
> been split to facilitate tracking should any of them run into the
> unlikely case of causing a regression.
> 
> Fixes: b2197755b263 ("bpf: add support for persistent maps/progs")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Acked-by: Alexei Starovoitov <ast@...nel.org>

Applied and queued up for -stable, thanks.