netdev - Re: [PATCH iproute2 -master] f_bpf: fix filling of handle when no further arg is provided

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160523161508.5523fe83@xeon-e3>
Date:	Mon, 23 May 2016 16:15:08 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	alexei.starovoitov@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 -master] f_bpf: fix filling of handle when no
 further arg is provided

On Wed, 18 May 2016 11:58:41 +0200
Daniel Borkmann <daniel@...earbox.net> wrote:

> We need to fill handle when provided by the user, even if no further
> argument is provided. Thus, move the test for arg to the correct location,
> so that it works correctly:
> 
>   # tc filter show dev foo egress
>   filter protocol all pref 1 bpf
>   filter protocol all pref 1 bpf handle 0x1 bpf.o:[classifier] direct-action
>   filter protocol all pref 1 bpf handle 0x2 bpf.o:[classifier] direct-action
>   # tc filter del dev foo egress prio 1 handle 2 bpf
>   # tc filter show dev foo egress
>   filter protocol all pref 1 bpf
>   filter protocol all pref 1 bpf handle 0x1 bpf.o:[classifier] direct-action
> 
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Applied