lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1464090769-29763-1-git-send-email-jhs@emojatatu.com> Date: Tue, 24 May 2016 07:52:48 -0400 From: Jamal Hadi Salim <jhs@...atatu.com> To: stephen@...workplumber.org Cc: netdev@...r.kernel.org, daniel@...earbox.net, Jamal Hadi Salim <jhs@...atatu.com> Subject: [iproute2 PATCH v2 1/1] tc simple action: bug fix From: Jamal Hadi Salim <jhs@...atatu.com> Failed compile m_simple.c: In function ‘parse_simple’: m_simple.c:154:6: warning: too many arguments for format [-Wformat-extra-args] *argv); ^ m_simple.c:103:14: warning: unused variable ‘maybe_bind’ [-Wunused-variable] Reported-by: Daniel Borkmann <daniel@...earbox.net> Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com> --- tc/m_simple.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tc/m_simple.c b/tc/m_simple.c index feba61b..27b3e5e 100644 --- a/tc/m_simple.c +++ b/tc/m_simple.c @@ -100,7 +100,7 @@ parse_simple(struct action_util *a, int *argc_p, char ***argv_p, int tca_id, struct tc_defact sel = {}; int argc = *argc_p; char **argv = *argv_p; - int ok = 0, maybe_bind = 0; + int ok = 0; struct rtattr *tail; char *simpdata = NULL; @@ -150,7 +150,7 @@ parse_simple(struct action_util *a, int *argc_p, char ***argv_p, int tca_id, if (matches(*argv, "index") == 0) { NEXT_ARG(); if (get_u32(&sel.index, *argv, 10)) { - fprintf(stderr, "simple: Illegal \"index\"\n", + fprintf(stderr, "simple: Illegal \"index\" (%s)\n", *argv); return -1; } @@ -171,7 +171,6 @@ parse_simple(struct action_util *a, int *argc_p, char ***argv_p, int tca_id, return -1; } - sel.action = TC_ACT_PIPE; tail = NLMSG_TAIL(n); -- 1.9.1
Powered by blists - more mailing lists