netdev - Re: [PATCH] net/qlge: Avoids recursive EEH error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160524.144818.1618490116569101413.davem@davemloft.net>
Date:	Tue, 24 May 2016 14:48:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gwshan@...ux.vnet.ibm.com
Cc:	netdev@...r.kernel.org, harish.patil@...gic.com,
	sudarsana.kalluru@...gic.com, shriyakul@...ibm.com
Subject: Re: [PATCH] net/qlge: Avoids recursive EEH error

From: Gavin Shan <gwshan@...ux.vnet.ibm.com>
Date: Mon, 23 May 2016 11:58:28 +1000

> One timer, whose handler keeps reading on MMIO register for EEH
> core to detect error in time, is started when the PCI device driver
> is loaded. MMIO register can't be accessed during PE reset in EEH
> recovery. Otherwise, the unexpected recursive error is triggered.
> The timer isn't closed that time if the interface isn't brought
> up. So the unexpected recursive error is seen during EEH recovery
> when the interface is down.
> 
> This avoids the unexpected recursive EEH error by closing the timer
> in qlge_io_error_detected() before EEH PE reset unconditionally. The
> timer is started unconditionally after EEH PE reset in qlge_io_resume().
> Also, the timer should be closed unconditionally when the device is
> removed from the system permanently in qlge_io_error_detected().
> 
> Reported-by: Shriya R. Kulkarni <shriyakul@...ibm.com>
> Signed-off-by: Gavin Shan <gwshan@...ux.vnet.ibm.com>

Applied, thanks.