netdev - Re: [PATCH net-next 1/2] net: vrf: Fix dst reference counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0df6d2f-f3f3-9938-658a-58d97cb6ab09@cumulusnetworks.com>
Date:	Wed, 25 May 2016 11:02:55 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	netdev@...r.kernel.org
Cc:	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next 1/2] net: vrf: Fix dst reference counting

I failed to update the auto-generated subject prefix in the patches. 
Both of these are for 4.5 stable not net-next.

On 5/25/16 10:35 AM, David Ahern wrote:
> commit 9ab179d83b4e31ea277a123492e419067c2f129a upstream
>
> Vivek reported a kernel exception deleting a VRF with an active
> connection through it. The root cause is that the socket has a cached
> reference to a dst that is destroyed. Converting the dst_destroy to
> dst_release and letting proper reference counting kick in does not
> work as the dst has a reference to the device which needs to be released
> as well.
>
> I talked to Hannes about this at netdev and he pointed out the ipv4 and
> ipv6 dst handling has dst_ifdown for just this scenario. Rather than
> continuing with the reinvented dst wheel in VRF just remove it and
> leverage the ipv4 and ipv6 versions.
>
> Fixes: 193125dbd8eb2 ("net: Introduce VRF device driver")
> Fixes: 35402e3136634 ("net: Add IPv6 support to VRF device")
>
> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>