netdev - Re: [PATCH net 4/4] net/mlx4_en: get rid of private net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1464267250.5939.78.camel@edumazet-glaptop3.roam.corp.google.com>
Date:	Thu, 26 May 2016 05:54:10 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tariq Toukan <ttoukan.linux@...il.com>
Cc:	Eric Dumazet <edumazet@...gle.com>,
	"David S . Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Willem de Bruijn <willemb@...gle.com>,
	Eugenia Emantayev <eugenia@...lanox.com>
Subject: Re: [PATCH net 4/4] net/mlx4_en: get rid of private net_device_stats

On Thu, 2016-05-26 at 12:38 +0300, Tariq Toukan wrote:
> Hi Eric,
> 
> Thanks for the fix.
> 
> > We do not need to clear fields that are already 0.
> Why is it always true that dev->stats is already 0 at the point ndo_open 
> is called?
> Is it true also in a flow of open -> stop -> open? I searched the kernel 
> stack for this but couldn't find.
> > @@ -1877,7 +1877,6 @@ static void mlx4_en_clear_stats(struct net_device *dev)
> >   	if (mlx4_en_DUMP_ETH_STATS(mdev, priv->port, 1))
> >   		en_dbg(HW, priv, "Failed dumping statistics\n");
> >   
> > -	memset(&priv->stats, 0, sizeof(priv->stats));
> >   	memset(&priv->pstats, 0, sizeof(priv->pstats));
> >   	memset(&priv->pkstats, 0, sizeof(priv->pkstats));
> >   	memset(&priv->port_stats, 0, sizeof(priv->port_stats));
> The role of this function is to clear the stats, no matter when and 
> where it is called.
> I am aware that clearing the stats structure might be redundant today, 
> as the function is called only within mlx4_en_open, but we might want to 
> call the function in other flows in the future.

This is the ' non obvious fix' we need to discuss for net-next

When we enslave a mlx4 NIC in a bonding driver, we sometime get
incorrect bond stats because mlx4 stats are reset.

These stats being computed using deltas, this can not work as is.

I believe the rule is to not clear the netdev stats at open()

Anyway, for this particular path, it does not matter, as
mlx4_en_DUMP_ETH_STATS() will set all the fields to their value.