netdev - Re: usbnet: smsc95xx: fix link detection for disabled autonegotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160526023120.GG21924@lunn.ch>
Date:	Thu, 26 May 2016 04:31:20 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Christoph Fritz <chf.fritz@...glemail.com>
Cc:	Steve Glendinning <steve.glendinning@...well.net>,
	netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>
Subject: Re: usbnet: smsc95xx: fix link detection for disabled autonegotiation

On Thu, May 26, 2016 at 04:06:47AM +0200, Christoph Fritz wrote:
> To detect link status up/down for connections where autonegotiation is
> explicitly disabled, we don't get an irq but need to poll the status
> register for link up/down detection.
> This patch adds a workqueue to poll for link status.

Did you consider using the phylib? It probably does the needed polling
already, and it looks like the functions needed to implement an MDIO
bus are already in place.

    Andrew