netdev - Re: [PATCH net] net: dsa: mv88e6xxx: Fix port forwarding mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87inxvbpgi.fsf@ketchup.mtl.sfl>
Date:	Mon, 30 May 2016 10:17:01 -0400
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Wojciech Dubowik <Wojciech.Dubowik@...atec.com>,
	davem@...emloft.net
Cc:	netdev@...r.kernel.org,
	Wojciech Dubowik <Wojciech.Dubowik@...atec.com>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Fix port forwarding mask

Hi Wojciech, David,

Wojciech Dubowik <Wojciech.Dubowik@...atec.com> writes:

> Port's vlan table is specified by bit mask and not by number.
> Only 4.4.x kernels are affected.
>
> Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@...atec.com>
> ---
>  drivers/net/dsa/mv88e6xxx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
> index 2dea39b..3e074d4 100644
> --- a/drivers/net/dsa/mv88e6xxx.c
> +++ b/drivers/net/dsa/mv88e6xxx.c
> @@ -2150,7 +2150,7 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds, int port)
>  	 * database, and allow every port to egress frames on all other ports.
>  	 */
>  	reg = BIT(ps->num_ports) - 1; /* all ports */
> -	ret = _mv88e6xxx_port_vlan_map_set(ds, port, reg & ~port);
> +	ret = _mv88e6xxx_port_vlan_map_set(ds, port, reg & ~BIT(port));
>  	if (ret)
>  		goto abort;

Commit be1faa92e83b ("net: dsa: mv88e6xxx: fix port VLAN maps") in
net/master already fixes this.

But indeed v4.5 contains be1faa92e83b but not v4.4.

Thanks,

        Vivien