lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGRGNgVRJm3zSokQ2wxb8Kwd4UEzx7ZjRCHAmnA02cB89Usy-A@mail.gmail.com> Date: Mon, 30 May 2016 15:21:15 +1000 From: Julian Calaby <julian.calaby@...il.com> To: Kirtika Ruchandani <kirtika.ruchandani@...il.com> Cc: Johannes Berg <johannes@...solutions.net>, linux-wireless <linux-wireless@...r.kernel.org>, Tina Ruchandani <ruchandani.tina@...il.com>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH v2 03/10] nl80211: Prefer ether_addr_copy Hi All, On Mon, May 30, 2016 at 12:52 PM, Kirtika Ruchandani <kirtika.ruchandani@...il.com> wrote: > This patch fixes the checkpatch,pl to prefer ether_addr_copy > over memcpy. > > Signed-off-by: Kirtika Ruchandani <kirtika.ruchandani@...il.com> This looks right to me, but doesn't ether_addr_copy() have alignment requirements? Could someone more familiar with that review these changes to ensure they're met? Thanks, Julian Calaby > --- > net/wireless/nl80211.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c > index cd422bd..34b8fbe 100644 > --- a/net/wireless/nl80211.c > +++ b/net/wireless/nl80211.c > @@ -3194,7 +3194,7 @@ static struct cfg80211_acl_data *parse_acl_data(struct wiphy *wiphy, > return ERR_PTR(-ENOMEM); > > nla_for_each_nested(attr, info->attrs[NL80211_ATTR_MAC_ADDRS], tmp) { > - memcpy(acl->mac_addrs[i].addr, nla_data(attr), ETH_ALEN); > + ether_addr_copy(acl->mac_addrs[i].addr, nla_data(attr)); > i++; > } > > @@ -5892,8 +5892,8 @@ static int nl80211_parse_random_mac(struct nlattr **attrs, > if (!attrs[NL80211_ATTR_MAC] || !attrs[NL80211_ATTR_MAC_MASK]) > return -EINVAL; > > - memcpy(mac_addr, nla_data(attrs[NL80211_ATTR_MAC]), ETH_ALEN); > - memcpy(mac_addr_mask, nla_data(attrs[NL80211_ATTR_MAC_MASK]), ETH_ALEN); > + ether_addr_copy(mac_addr, nla_data(attrs[NL80211_ATTR_MAC])); > + ether_addr_copy(mac_addr_mask, nla_data(attrs[NL80211_ATTR_MAC_MASK])); > > /* don't allow or configure an mcast address */ > if (!is_multicast_ether_addr(mac_addr_mask) || > @@ -9405,8 +9405,7 @@ static int nl80211_parse_wowlan_tcp(struct cfg80211_registered_device *rdev, > return -ENOMEM; > cfg->src = nla_get_in_addr(tb[NL80211_WOWLAN_TCP_SRC_IPV4]); > cfg->dst = nla_get_in_addr(tb[NL80211_WOWLAN_TCP_DST_IPV4]); > - memcpy(cfg->dst_mac, nla_data(tb[NL80211_WOWLAN_TCP_DST_MAC]), > - ETH_ALEN); > + ether_addr_copy(cfg->dst_mac, nla_data(tb[NL80211_WOWLAN_TCP_DST_MAC])); > if (tb[NL80211_WOWLAN_TCP_SRC_PORT]) > port = nla_get_u16(tb[NL80211_WOWLAN_TCP_SRC_PORT]); > else > -- > 2.8.0.rc3.226.g39d4020 > -- Julian Calaby Email: julian.calaby@...il.com Profile: http://www.google.com/profiles/julian.calaby/
Powered by blists - more mailing lists