netdev - Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGRGNgUbMQ5eh3aYdcRmoO7Qea_XTKzSXLYjf1NEAu6ZdJLPVg@mail.gmail.com>
Date:	Mon, 30 May 2016 16:06:26 +1000
From:	Julian Calaby <julian.calaby@...il.com>
To:	Kirtika Ruchandani <kirtika.ruchandani@...il.com>
Cc:	Johannes Berg <johannes@...solutions.net>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	Tina Ruchandani <ruchandani.tina@...il.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

Hi Kirtika,

On Mon, May 30, 2016 at 4:04 PM, Kirtika Ruchandani
<kirtika.ruchandani@...il.com> wrote:
>> Adding the brackets around the & expression doesn't look spacing
>> related to me. What's the exact warning this is fixing?
>
> From the commit message - "This patch also contains two hunks to fix
> 'line over 80 characters',
> that are spacing related". This is the second hunk, the first being
> the comments in the nl80211_fam
> definition. Should I resend with these two hunks omitted, or fix my wording?

That explains it, I missed that bit.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/