netdev - Re: [PATCH net v3] virtio_net: fix virtnet_open and virtnet_probe competing for try_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160531.142259.185396177679283647.davem@davemloft.net>
Date:	Tue, 31 May 2016 14:22:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wangyunjian@...wei.com
Cc:	jasowang@...hat.com, mst@...hat.com, rusty@...tcorp.com.au,
	netdev@...r.kernel.org, liuyongan@...wei.com
Subject: Re: [PATCH net v3] virtio_net: fix virtnet_open and virtnet_probe
 competing for try_fill_recv

From: Yunjian Wang <wangyunjian@...wei.com>
Date: Tue, 31 May 2016 11:52:43 +0800

> In function virtnet_open() and virtnet_probe(), func try_fill_recv() may
> be executed at the same time. VQ in virtqueue_add() has not been protected
> well and BUG_ON will be triggered when virito_net.ko being removed.
> 
> Signed-off-by: Yunjian Wang <wangyunjian@...wei.com>
> Acked-by: Jason Wang <jasowang@...hat.com>
> Acked-by: Michael S. Tsirkin <mst@...hat.com>

Applied.