netdev - Re: [patch] atm: firestream: add more reserved strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160531.115312.2224370646479410237.davem@davemloft.net>
Date:	Tue, 31 May 2016 11:53:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	3chas3@...il.com, patrick@...wizard.nl,
	linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] atm: firestream: add more reserved strings

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Fri, 27 May 2016 13:33:50 +0300

> This bug was there when the driver was first added in back in year 2000.
> It causes a Smatch warning:
> 
>     drivers/atm/firestream.c:849 process_incoming()
>     error: buffer overflow 'res_strings' 60 <= 63
> 
> There are supposed to be 64 entries in this array and the missing
> strings are clearly in the 30 40 range.  I added them as reserved 37 to
> reserved 40.  It's possible that strings are really supposed to be added
> in the middle instead of at the end, but this approach is safe, in that
> it fixes the bug and doesn't break anything that wasn't already broken.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.