netdev - Re: [PATCH net v2 1/1] net: fec: update dirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160531.115828.1504167795656808366.davem@davemloft.net>
Date:	Tue, 31 May 2016 11:58:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	troy.kisky@...ndarydevices.com
Cc:	netdev@...r.kernel.org, fugang.duan@....com, lznuaa@...il.com,
	fabio.estevam@....com, l.stach@...gutronix.de, andrew@...n.ch,
	tremyfr@...il.com, gerg@...inux.org, johannes@...solutions.net,
	stillcompiling@...il.com, sergei.shtylyov@...entembedded.com,
	arnd@...db.de, holgerschurig@...il.com
Subject: Re: [PATCH net v2 1/1] net: fec: update dirty_tx even if no skb

From: Troy Kisky <troy.kisky@...ndarydevices.com>
Date: Fri, 27 May 2016 13:30:40 -0700

> If dirty_tx isn't updated, then dma_unmap_single
> can be called twice.
> 
> This fixes a
> [   58.420980] ------------[ cut here ]------------
> [   58.425667] WARNING: CPU: 0 PID: 377 at /home/schurig/d/mkarm/linux-4.5/lib/dma-debug.c:1096 check_unmap+0x9d0/0xab8()
> [   58.436405] fec 2188000.ethernet: DMA-API: device driver tries to free DMA memory it has not allocated [device address=0x0000000000000000] [size=66 bytes]
> 
> encountered by Holger
> 
> Signed-off-by: Troy Kisky <troy.kisky@...ndarydevices.com>
> Tested-by: <holgerschurig@...il.com>
> Acked-by: Fugang Duan <fugang.duan@....com>

Applied.