netdev - Re: [PATCH net v2] openvswitch: update checksum in {push,pop}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160531.135203.2078504589397948891.davem@davemloft.net>
Date:	Tue, 31 May 2016 13:52:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	simon.horman@...ronome.com
Cc:	pshelar@....org, netdev@...r.kernel.org, pshelar@...ira.com
Subject: Re: [PATCH net v2] openvswitch: update checksum in {push,pop}_mpls

From: Simon Horman <simon.horman@...ronome.com>
Date: Mon, 30 May 2016 14:04:25 +0900

> In the case of CHECKSUM_COMPLETE the skb checksum should be updated in
> {push,pop}_mpls() as they the type in the ethernet header.
> 
> As suggested by Pravin Shelar.
> 
> Cc: Pravin Shelar <pshelar@...ira.com>
> Fixes: 25cd9ba0abc0 ("openvswitch: Add basic MPLS support to kernel")
> Signed-off-by: Simon Horman <simon.horman@...ronome.com>
> ---
> v2
> * Use helper to reduce duplicated code.

Applied, thanks Simon.