netdev - Re: [PATCH] fou: fix IPv6 Kconfig options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160531.140804.27676513823707793.davem@davemloft.net>
Date:	Tue, 31 May 2016 14:08:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	arnd@...db.de
Cc:	tom@...bertland.com, valentinrothberg@...il.com, ziegler@...fau.de,
	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fou: fix IPv6 Kconfig options

From: Arnd Bergmann <arnd@...db.de>
Date: Tue, 31 May 2016 22:42:11 +0200

> The Kconfig options I added to work around broken compilation ended
> up screwing up things more, as I used the wrong symbol to control
> compilation of the file, resulting in IPv6 fou support to never be built
> into the kernel.
> 
> Changing CONFIG_NET_FOU_IPV6_TUNNELS to CONFIG_IPV6_FOU fixes that
> problem, I had renamed the symbol in one location but not the other,
> and as the file is never being used by other kernel code, this did not
> lead to a build failure that I would have caught.
> 
> After that fix, another issue with the same patch becomes obvious, as we
> 'select INET6_TUNNEL', which is related to IPV6_TUNNEL, but not the same,
> and this can still cause the original build failure when IPV6_TUNNEL is
> not built-in but IPV6_FOU is. The fix is equally trivial, we just need
> to select the right symbol.
> 
> I have successfully build 350 randconfig kernels with this patch
> and verified that the driver is now being built.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Reported-by: Valentin Rothberg <valentinrothberg@...il.com>
> Fixes: fabb13db448e ("fou: add Kconfig options for IPv6 support")

Applied, thanks Arnd.