netdev - Re: [PATCH net] bnx2x: avoid leaking memory on bnx2x_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160531.141111.2242150565551090751.davem@davemloft.net>
Date:	Tue, 31 May 2016 14:11:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vkuznets@...hat.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	ariel.elior@...gic.com
Subject: Re: [PATCH net] bnx2x: avoid leaking memory on bnx2x_init_one()
 failures

From: Vitaly Kuznetsov <vkuznets@...hat.com>
Date: Mon, 30 May 2016 15:00:54 +0200

> bnx2x_init_bp() allocates memory with bnx2x_alloc_mem_bp() so if we
> fail later in bnx2x_init_one() we need to free this memory
> with bnx2x_free_mem_bp() to avoid leakages. E.g. I'm observing memory
> leaks reported by kmemleak when a failure (unrelated) happens in
> bnx2x_vfpf_acquire().
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>

Applied.