netdev - Re: [iproute PATCH] ipaddress: Allow listing addresses by type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160601215001.GA13978@angus-think.lan>
Date:	Thu, 2 Jun 2016 00:50:01 +0300
From:	Vadim Kochan <vadim4j@...il.com>
To:	Phil Sutter <phil@....cc>
Cc:	Stephen Hemminger <shemming@...cade.com>, netdev@...r.kernel.org,
	Vadim Kochan <vadim4j@...il.com>
Subject: Re: [iproute PATCH] ipaddress: Allow listing addresses by type

On Wed, Jun 01, 2016 at 09:57:27PM +0200, Phil Sutter wrote:
> Not sure why this was limited to ip-link before. It is semantically
> equal to the 'master' keyword, which is not restricted at all.
> 
Hi Phil,

I don't remember why I did so, but you are right, it might be
used for 'ip addr' too.

> Cc: Vadim Kochan <vadim4j@...il.com>
> Signed-off-by: Phil Sutter <phil@....cc>
> ---
>  ip/ipaddress.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index df363b070d5de..1b5ee838ef3fe 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -1613,7 +1613,7 @@ static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
>  			if (!ifindex)
>  				invarg("Device does not exist\n", *argv);
>  			filter.master = ifindex;
> -		} else if (do_link && strcmp(*argv, "type") == 0) {
> +		} else if (strcmp(*argv, "type") == 0) {
>  			NEXT_ARG();
>  			filter.kind = *argv;
>  		} else {
> -- 
> 2.8.2
>