lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <574F6168.3020802@codeaurora.org> Date: Wed, 1 Jun 2016 17:27:52 -0500 From: Timur Tabi <timur@...eaurora.org> To: Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org, sdharia@...eaurora.org, Shanker Donthineni <shankerd@...eaurora.org>, Greg Kroah-Hartman <greg@...ah.com>, vikrams@...eaurora.org, cov@...eaurora.org, gavidov@...eaurora.org, Rob Herring <robh+dt@...nel.org>, andrew@...n.ch, bjorn.andersson@...aro.org, Mark Langsdorf <mlangsdo@...hat.com>, Jon Masters <jcm@...hat.com>, Andy Gross <agross@...eaurora.org>, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver Florian Fainelli wrote: >> +/* Transmit the packet */ >> >+static int emac_start_xmit(struct sk_buff *skb, struct net_device *netdev) >> >+{ >> >+ struct emac_adapter *adpt = netdev_priv(netdev); >> >+ >> >+ return emac_mac_tx_buf_send(adpt, &adpt->tx_q, skb); > I would inline emac_mac_tx_buf_send()'s body here to make it much easier > to read and audit... I'm close to submitting a v5 of this patchset. The change to phylib has resulted in significant other changes. I'm sure it's still not quite right, so I ask your patience in reviewing it. However, I'm not sure inlining emac_mac_tx_buf_send() into emac_start_xmit() is good idea. That would result in moving several functions from emac-mac.c into emac.c. I'm concerned about maintaining the functional split between the two files. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation collaborative project.
Powered by blists - more mailing lists