lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20160601.161805.1142999841225463527.davem@davemloft.net> Date: Wed, 01 Jun 2016 16:18:05 -0700 (PDT) From: David Miller <davem@...emloft.net> To: pramod.kumar@...adcom.com Cc: robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com, ijc+devicetree@...lion.org.uk, galak@...eaurora.org, catalin.marinas@....com, will.deacon@....com, kishon@...com, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, bcm-kernel-feedback-list@...adcom.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs From: Pramod Kumar <pramod.kumar@...adcom.com> Date: Tue, 31 May 2016 19:06:39 +0530 > +static int iproc_mdio_wait_for_idle(void __iomem *base, bool result) > +{ > + u32 val; > + unsigned int timeout = 1000; /* loop for 1s */ Please order your local variable declarations from longest to shortest line. > +static int start_miim_ops(void __iomem *base, > + u16 phyid, u32 reg, u16 val, u32 op) > +{ > + int ret; > + u32 param; Likewise. > +static int iproc_mdiomux_read(struct mii_bus *bus, int phyid, int reg) > +{ > + int ret; > + struct iproc_mdiomux_desc *md = bus->priv; Likewise.
Powered by blists - more mailing lists