lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGRGNgXYBucEh+D3ceHR5xg4fPuNhx-CCjHPRewhNWZJzgV-kg@mail.gmail.com> Date: Wed, 1 Jun 2016 14:17:19 +1000 From: Julian Calaby <julian.calaby@...il.com> To: Javier Martinez Canillas <javier@....samsung.com> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Xinming Hu <huxm@...vell.com>, Amitkumar Karwar <akarwar@...vell.com>, Kalle Valo <kvalo@...eaurora.org>, netdev <netdev@...r.kernel.org>, linux-wireless <linux-wireless@...r.kernel.org>, Nishant Sarmukadam <nishants@...vell.com> Subject: Re: [PATCH 3/8] mwifiex: propagate mwifiex_add_card() errno code in mwifiex_sdio_probe() Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas <javier@....samsung.com> wrote: > There's only a check if mwifiex_add_card() returned a nonzero value, but > the actual error code is neither stored nor propagated to the caller. So > instead of always returning -1 (which is -EPERM and not a suitable errno > code in this case), propagate the value returned by mwifiex_add_card(). > > Patch also removes the assignment of sdio_disable_func() returned value > since it was overwritten anyways and what matters is to know the error > value returned by the first function that failed. > > Signed-off-by: Javier Martinez Canillas <javier@....samsung.com> This looks sensible to me. Reviewed-by: Julian Calaby <julian.calaby@...il.com> > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Thanks, -- Julian Calaby Email: julian.calaby@...il.com Profile: http://www.google.com/profiles/julian.calaby/
Powered by blists - more mailing lists