netdev - Re: [RFC 02/12] net: cls_bpf: add hardware offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160602130712.54b9575e@jkicinski-Precision-T1700>
Date:	Thu, 2 Jun 2016 13:07:12 +0100
From:	Jakub Kicinski <jakub.kicinski@...ronome.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev@...r.kernel.org, ast@...nel.org, daniel@...earbox.net,
	dinan.gunawardena@...ronome.com
Subject: Re: [RFC 02/12] net: cls_bpf: add hardware offload

On Thu, 2 Jun 2016 09:17:15 +0200, Jiri Pirko wrote:
> >+static void cls_bpf_stop_offload(struct tcf_proto *tp,
> >+				 struct cls_bpf_prog *prog)
> >+{
> >+	struct net_device *dev = tp->q->dev_queue->dev;
> >+
> >+	if (!prog->offloaded)
> >+		return;
> >+	if (WARN_ON(!tc_should_offload(dev, 0)))
> >+		return;
> >+
> >+	if (cls_bpf_offload_cmd(tp, prog, TC_CLSBPF_DESTROY)) {  
> 
> Please do:
> err = 
> if (err)

Sure!