lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160602145729.GO14868@mtj.duckdns.org> Date: Thu, 2 Jun 2016 10:57:29 -0400 From: Tejun Heo <tj@...nel.org> To: Bhaktipriya Shridhar <bhaktipriya96@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, Taku Izumi <izumi.taku@...fujitsu.com>, Florian Westphal <fw@...len.de>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: fjes: fjes_main: Remove create_workqueue On Thu, Jun 02, 2016 at 03:00:57PM +0530, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > The workqueue adapter->txrx_wq has workitem > &adapter->raise_intr_rxdata_task per adapter. Extended Socket Network > Device is shared memory based, so someone's transmission denotes other's > reception. raise_intr_rxdata_task raises interruption of receivers from > the sender in order to notify receivers. > > The workqueue adapter->control_wq has workitem > &adapter->interrupt_watch_task per adapter. interrupt_watch_task is used > to prevent delay of interrupts. > > Dedicated workqueues have been used in both cases since the workitems > on the workqueues are involved in normal device operation and require > forward progress under memory pressure. > > max_active has been set to 0 since there is no need for throttling > the number of active work items. > > Since network devices may be used for memory reclaim, > WQ_MEM_RECLAIM has been set to guarantee forward progress. Patch looks good but ditto with the description. I wish it were clearer. Thanks. -- tejun
Powered by blists - more mailing lists