netdev - Re: [PATCH v2 2/5] fsl/qe: setup clock source for TDM mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160602.122451.160749876120675817.davem@davemloft.net>
Date:	Thu, 02 Jun 2016 12:24:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	qiang.zhao@....com
Cc:	oss@...error.net, linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	xiaobo.xie@....com
Subject: Re: [PATCH v2 2/5] fsl/qe: setup clock source for TDM mode

From: Zhao Qiang <qiang.zhao@....com>
Date: Thu, 2 Jun 2016 09:44:58 +0800

> +static int ucc_get_tdm_sync_source(u32 tdm_num, enum qe_clock clock,
> +				   enum comm_dir mode)
> +{
> +	int source = -EINVAL;
> +
> +	if (mode == COMM_DIR_RX && clock == QE_RSYNC_PIN) {
> +		source = 0;
> +		return source;
> +	}
> +	if (mode == COMM_DIR_TX && clock == QE_TSYNC_PIN) {
> +		source = 0;
> +		return source;
> +	}
> +
> +	switch (tdm_num) {
> +	case 0:
> +	case 1:
> +		switch (clock) {
> +		case QE_BRG9:
> +				source = 1;
> +				break;
> +		case QE_BRG10:
> +				source = 2;
> +				break;

These switch case bodies are over indented.  Same goes for the rest of
this function.