lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <cfff846f3ca34b6a889f07f971b27271@ausx13mpc124.AMER.DELL.COM> Date: Thu, 2 Jun 2016 02:53:06 +0000 From: <Mario_Limonciello@...l.com> To: <gregkh@...uxfoundation.org> CC: <hayeswang@...ltek.com>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <linux-usb@...r.kernel.org>, <pali.rohar@...il.com>, <anthony.wong@...onical.com> Subject: RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address > > +static u8 amac_ascii_to_hex(int c) > > +{ > > + if (c <= 0x39) > > + return (u8)(c - 0x30); > > + else if (c <= 0x46) > > + return (u8)(c - 0x37); > > + return (u8)(c - 0x57); > > +} > Sorry forgot to address this. > We really don't have such a function somewhere in the kernel already? There is a function in acpi/acpica/uthex.c that does this, but it doesn't seem to be used by anything outside of acpica so far. Would it be OK style wise to #include " ../../acpi/acpica/acutils.h" from r8152.c? If not, then what is the proper thing to do here to re-use it from there? > And why 'int', isn't "c" really a u8? Yeah I guess u8 should be fine there, and avoid the casting then too.
Powered by blists - more mailing lists