netdev - Re: [PATCH][V2] net/ethoc: fix null dereference on error exit path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160601.220220.760215551109095573.davem@davemloft.net>
Date:	Wed, 01 Jun 2016 22:02:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	colin.king@...onical.com
Cc:	andrew@...n.ch, f.fainelli@...il.com, tklauser@...tanz.ch,
	jcmvbkbc@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] net/ethoc: fix null dereference on error exit path

From: Colin King <colin.king@...onical.com>
Date: Wed,  1 Jun 2016 14:16:50 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> priv is assigned to NULL however some of the early error exit paths to
> label 'free' dereference priv, causing a null pointer dereference.
> 
> Move the label 'free' to just the free_netdev statement, and add a new
> exit path 'free2' for the error cases were clk_disable_unprepare needs
> calling before the final free.
> 
> Fixes issue found by CoverityScan, CID#113260
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.