lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87lh2oyrrz.fsf@nemi.mork.no> Date: Thu, 02 Jun 2016 09:27:28 +0200 From: Bjørn Mork <bjorn@...k.no> To: Mario Limonciello <mario_limonciello@...l.com> Cc: Greg KH <gregkh@...uxfoundation.org>, hayeswang@...ltek.com, LKML <linux-kernel@...r.kernel.org>, Netdev <netdev@...r.kernel.org>, Linux USB <linux-usb@...r.kernel.org>, pali.rohar@...il.com, anthony.wong@...onical.com Subject: Re: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Greg KH <gregkh@...uxfoundation.org> writes: > And finally, this seems odd overall given that a MAC address should be > associated with the specific network device, not the overall system. Definitely. I wonder if this isn't a perfect candidate for an x86 arch_get_platform_mac_address() implementation? Then you could just use the eth_platform_get_mac_address() helper in the driver and avoid any platform specific code there. Which will automagically make it work as expected on a Sparc too :) This will also make your job next year much easier, when the hardeware guys decided to replace the chip and you need to implement the exact same code in some other driver... See https://patchwork.ozlabs.org/patch/564100/ for a detailed discussion of this interface. Bjørn
Powered by blists - more mailing lists