lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <574FEEF6.1080109@miraclelinux.com> Date: Thu, 2 Jun 2016 17:31:50 +0900 From: YOSHIFUJI Hideaki <hideaki.yoshifuji@...aclelinux.com> To: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>, netdev@...r.kernel.org Cc: hideaki.yoshifuji@...aclelinux.com Subject: Re: [PATCH iputils 5/6] tftpd: fix syslog setup Hi, Mike Frysinger wrote: > On 02 Jun 2016 11:10, YOSHIFUJI Hideaki wrote: >> Mike Frysinger wrote: >>> Commit d81a44625b04d487c895473aa77af13420b7afdd added support for checking >>> the set*id calls, but would call syslog() before it had called openlog(). >>> Move the call up earlier to fix that. >> >> Please describe what it really fixes. > > i already did: you need to call openlog before calling syslog, but the > code here very clearly doesn't. if you read the commit i referenced, > and the all <25 lines of context here, it should be pretty obvious the > code is wrong. > -mike > OK, applied. Thank you. -- Hideaki Yoshifuji <hideaki.yoshifuji@...aclelinux.com> Technical Division, MIRACLE LINUX CORPORATION
Powered by blists - more mailing lists