netdev - Re: [PATCH net-next 00/17] New DSA bind, switches as devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5751BF76.9020301@gmail.com>
Date:	Fri, 3 Jun 2016 10:33:42 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>,
	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 00/17] New DSA bind, switches as devices

On 06/03/2016 09:43 AM, Andrew Lunn wrote:
> The interesting patches here are the last three. They implement a new
> binding for DSA, which removes a few limitations of the current DSA
> binding. In particular, it allows switches to be true Linux devices.
> These devices can be on any type of bus, unlike the old DSA binding
> which assumes MDIO. See the commit log for more details. The second to
> last patch modifies an existing boards device tree to use the new
> binding, giving a good example of how switches can be true MDIO
> devices. The last patch documents the new binding.
> 
> I know both John Crispin and Bryan Whitehead are interesting in
> implementing DSA drivers, hence i have CC: you. Comments welcome.
> 
> Thanks go to Florian and Vivien for reviewing, testing and bug fixing
> these patches.

Will keep reviewing patches by one, but a quick smoke test here on a
BCM7445 with bcm_sf2 gives me all thumbs up.

Tested-by: Florian Fainelli <f.fainelli@...il.com>

Thanks!

> 
> Since RFC:
> 
> * Split the mv88e6xxx MDIO refactor into a rename patch and a refactor
>   patch.
> * Extend commit message with comment about wrong of_node_put()
> * Fix destroy of cpu and dsa ports.
> * Rename _DSA_TAG_LAST to DSA_TAG_LAST and add a comment.
> 
> Andrew Lunn (16):
>   net: dsa: slave: chip data is optional, don't dereference NULL
>   net: dsa: slave: Remove MDIO address from switch MDIO bus name
>   net: dsa: tag_{e}dsa.c: Remove dependency on platform data
>   net: dsa: Add a ports structure and use it in the switch structure
>   net: dsa: Move port device node into port structure
>   net: dsa: Remove dynamic allocate of routing table
>   net: dsa: Copy the routing table into the switch structure
>   net: dsa: Split up creating/destroying of DSA and CPU ports
>   net: dsa: mv88e6xxx: Only support EDSA tagging
>   net: dsa: Refactor selection of tag ops into a function
>   net: dsa: Make mdio bus optional
>   net: dsa: mv88e6xxx: Rename _phy_ to _mdio_
>   net: dsa: mv88e6xxx: Refactor MDIO so driver registers mdio bus
>   net: dsa: Add new binding implementation
>   arm: dt: vf610-zii-devel-b: Make use of new DSA binding
>   net: dsa: Document new binding
> 
> Vivien Didelot (1):
>   net: dsa: mv88e6xxx: fix circular lock in PPU work
> 
>  Documentation/devicetree/bindings/net/dsa/dsa.txt | 278 ++++++++-
>  arch/arm/boot/dts/vf610-zii-dev-rev-b.dts         | 328 +++++------
>  drivers/net/dsa/bcm_sf2.c                         |   4 +-
>  drivers/net/dsa/mv88e6xxx.c                       | 267 ++++++---
>  drivers/net/dsa/mv88e6xxx.h                       |   6 +
>  include/net/dsa.h                                 |  56 +-
>  net/dsa/Makefile                                  |   2 +-
>  net/dsa/dsa.c                                     | 210 ++++---
>  net/dsa/dsa2.c                                    | 653 ++++++++++++++++++++++
>  net/dsa/dsa_priv.h                                |   6 +-
>  net/dsa/slave.c                                   |  57 +-
>  net/dsa/tag_brcm.c                                |   4 +-
>  net/dsa/tag_dsa.c                                 |  10 +-
>  net/dsa/tag_edsa.c                                |  10 +-
>  net/dsa/tag_trailer.c                             |   4 +-
>  15 files changed, 1485 insertions(+), 410 deletions(-)
>  create mode 100644 net/dsa/dsa2.c
> 


-- 
Florian