netdev - Re: [PATCH v2] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57520291.7090004@iogearbox.net>
Date:	Sat, 04 Jun 2016 00:20:01 +0200
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Helge Deller <deller@....de>,
	Alexei Starovoitov <alexei.starovoitov@...il.com>
CC:	Craig Gallek <kraigatgoog@...il.com>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Alexei Starovoitov <ast@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>,
	Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH v2] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT_CBPF

On 06/03/2016 11:49 PM, Helge Deller wrote:
> Commit 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF")
> missed to add the compat case for the SO_ATTACH_REUSEPORT_CBPF option.
>
> Signed-off-by: Helge Deller <deller@....de>

LGTM, thanks!

Acked-by: Daniel Borkmann <daniel@...earbox.net>

[ Cc Willem: I believe we also need something similar for PACKET_FANOUT_DATA
   when PACKET_FANOUT_CBPF is requested since we have the same issue with the
   pointer in struct sock_fprog there, too. ]

> diff --git a/net/compat.c b/net/compat.c
> index 5cfd26a..1373947 100644
> --- a/net/compat.c
> +++ b/net/compat.c
> @@ -354,7 +354,8 @@ static int do_set_sock_timeout(struct socket *sock, int level,
>   static int compat_sock_setsockopt(struct socket *sock, int level, int optname,
>   				char __user *optval, unsigned int optlen)
>   {
> -	if (optname == SO_ATTACH_FILTER)
> +	if (optname == SO_ATTACH_FILTER ||
> +	    optname == SO_ATTACH_REUSEPORT_CBPF)
>   		return do_set_attach_filter(sock, level, optname,
>   					    optval, optlen);
>   	if (optname == SO_RCVTIMEO || optname == SO_SNDTIMEO)
>