netdev - Re: Possible problem with e6afc8ac ("udp: remove headers from UDP packets before queueing")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1464922706.5939.186.camel@edumazet-glaptop3.roam.corp.google.com>
Date:	Thu, 02 Jun 2016 19:58:26 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	paul@...l-moore.com, samanthakumar@...gle.com,
	linux-security-module@...r.kernel.org, selinux@...ho.nsa.gov,
	netdev@...r.kernel.org, sds@...ho.nsa.gov
Subject: Re: Possible problem with e6afc8ac ("udp: remove headers from UDP
 packets before queueing")

On Thu, 2016-06-02 at 18:31 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Thu, 02 Jun 2016 14:52:43 -0700
> 
> > From: Eric Dumazet <edumazet@...gle.com>
> > 
> > Paul Moore tracked a regression caused by a recent commit, which
> > mistakenly assumed that sk_filter() could be avoided if socket
> > had no current BPF filter.
> > 
> > The intent was to avoid udp_lib_checksum_complete() overhead.
> > 
> > But sk_filter() also checks skb_pfmemalloc() and
> > security_sock_rcv_skb(), so better call it.
> > 
> > Fixes: e6afc8ace6dd ("udp: remove headers from UDP packets before queueing")
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > Reported-by: Paul Moore <paul@...l-moore.com>
> > Tested-by: Paul Moore <paul@...l-moore.com>
> > Tested-by: Stephen Smalley <sds@...ho.nsa.gov>
> > Cc: samanthakumar <samanthakumar@...gle.com>
> 
> Applied, thanks Eric.

Arg, I totally messed up the patch title :(